Skip to content

6000.1 branchoff#8119

Merged
theopnv merged 6 commits into6000.1/stagingfrom
6000.1/branchoff
Jan 22, 2025
Merged

6000.1 branchoff#8119
theopnv merged 6 commits into6000.1/stagingfrom
6000.1/branchoff

Conversation

@theopnv
Copy link
Contributor

@theopnv theopnv commented Jan 17, 2025 •
edited
Loading

Purpose of this PR

Turn nightly into weekly, remove the ppv2 jobs (they are only relevant for master).

Testing status

Weekly: https://unity-ci.cds.internal.unity3d.com/project/902/branch/6000.1%2Fbranchoff/jobDefinition/.yamato%2F_abv.yml%23graphics_repo_weekly_6000.1?nav=jobDefinitions

@theopnv theopnv requested a review from a team as a code owner January 17, 2025 09:32
@theopnv theopnv requested a review from a team as a code owner January 17, 2025 12:23
theopnv
theopnv commented Jan 17, 2025
View reviewed changes
...iversal/Packages/com.unity.template.universal/Tests/Editor/InternalTests/ExpectedSettings.cs
yield return new TestCaseData(BuildTarget.iOS);
yield return new TestCaseData(BuildTarget.PS4);
yield return new TestCaseData(BuildTarget.PS5);
yield return new TestCaseData(BuildTarget.Stadia);
Copy link
Contributor Author

@theopnv theopnv Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing https://unity-ci.cds.internal.unity3d.com/job/45731047/results?r=45731046

theopnv
theopnv commented Jan 17, 2025
View reviewed changes
com.unity.template.hdrp-blank/Packages/com.unity.template.hdrp-blank/CHANGELOG.md

## [17.0.6] - 2024-10-09

## Changed
Copy link
Contributor Author

@theopnv theopnv Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing https://unity-ci.cds.internal.unity3d.com/job/45731045/results?r=45731046

Copy link
Contributor Author

@theopnv theopnv Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: actual fix seems to bump the template, see below. It was probably missed in #8104

@theopnv
Copy link
Contributor Author

theopnv commented Jan 17, 2025 •
edited
Loading

Hi @PatrickSycz , could you look at the hdrp blank template changes and confirm they are fine? I think we forgot them in this PR.
@Unity-Technologies/universal-rp-team could you have a look at the Stadia removal from the templates internal tests and also confirm this is fine?
There's also #8120 for master.
Thanks a lot.

@theopnv theopnv requested a review from PatrickSycz January 17, 2025 14:36
@theopnv theopnv mentioned this pull request Jan 17, 2025
Merged
@PatrickSycz
Copy link
Contributor

PatrickSycz commented Jan 18, 2025

Hi @PatrickSycz , could you look at the hdrp blank template changes and confirm they are fine? I think we forgot them in this PR. @Unity-Technologies/universal-rp-team could you have a look at the Stadia removal from the templates internal tests and also confirm this is fine? There's also #8120 for master. Thanks a lot.

Hi @theopnv, I didn't notice any incorrect template changes. Keep in mind that I'm quiet new to how templates work 😂

@theopnv theopnv merged commit 6a4b780 into 6000.1/staging Jan 22, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PatrickSycz PatrickSycz PatrickSycz approved these changes

+1 more reviewer

@varticcata varticcata varticcata approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theopnv @PatrickSycz @varticcata @theo-at-unity